[EXPORTER] Add HttpHeaders in ElasticsearchLogRecordExporter#3083
Merged
marcalff merged 1 commit intoOct 7, 2024
Merged
Conversation
|
|
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
marcalff
changed the title
ElasticsearchLogRecordExporter (open-telemetry#3080) Closes open-telemetry#3080
ShadowMaxLeb
force-pushed
the
custom-http-headers-elastic-search-exporter
branch
from
b7dc9e1 to
f2974a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3083 +/- ##
==========================================
+ Coverage 87.12% 87.81% +0.69%
==========================================
Files 200 195 -5
Lines 6109 5968 -141
==========================================
- Hits 5322 5240 -82
+ Misses 787 728 -59 |
lalitb
approved these changes
Oct 7, 2024
marcalff
approved these changes
Oct 7, 2024
marcalff
left a comment
marcalff
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3080
When using the
ElasticsearchLogRecordExporterwe might need to add some http headers (auth or other required headers by our server). As of today there was no way of doing it for this exporter.This PR aims to add this feature.
Changes
Like for the HttpLogRecordExporter, add the possibility to give custom http headers that will be added to each request. This is done by adding a
std::multimapin which headers are added and then parsed when the request is being sent.