[bazel] Enable --incompatible_disallow_empty_glob#2642
Conversation
This way downstream consumers can enable this flag as well
|
I have a list in my soft fork, with few more incompatbiles that were enabled (whatever I can) - https://github.com/malkia/opentelemetry-cpp/blob/main/.bazelrc#L92 - although that specifically did not work - I think it was for the prometheus-cpp module? |
|
depends on jupp0r/prometheus-cpp#715 and probably some other stuff |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2642 +/- ##
=======================================
Coverage 87.86% 87.86%
=======================================
Files 195 195
Lines 6151 6151
=======================================
Hits 5404 5404
Misses 747 747
|
This PR in prometheus-cpp: is merged, but there is no release yet that includes it. Opentelemetry-cpp is using the prometheus-cpp 1.2.4 tag. Waiting on release 1.2.5 from prometheus (adding blocked tag) |
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
|
will rebase after #3162 |
This way downstream consumers can enable this flag as well