Fix build warnings#1613
Merged
Merged
Conversation
Fix build warnings reported by gcc 10, with: -Wall -Werror -Wextra-semi -Werror=unused-parameter -Werror=undef
ThomsonTan
reviewed
Sep 13, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1613 +/- ##
==========================================
- Coverage 85.24% 85.22% -0.02%
==========================================
Files 156 156
Lines 4978 4978
==========================================
- Hits 4243 4242 -1
- Misses 735 736 +1
|
lalitb
approved these changes
Sep 13, 2022
lalitb
left a comment
Member
There was a problem hiding this comment.
Looks good to me, but as it's bigger cleanup, will wait for one more approval :). Thanks for taking this.
remove debug code
owent
approved these changes
Sep 14, 2022
owent
left a comment
Member
There was a problem hiding this comment.
LGTM after the dead codes removed.
owent
approved these changes
Sep 14, 2022
Member
Author
|
The DocFX check build failed due to this: which looks like a transient error unrelated to the change. This PR is ready for merge now. |
Member
|
related to #249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1611
Changes
Fix build warnings reported by gcc 10, with:
-Wall -Werror
-Wextra-semi
-Werror=unused-parameter
-Werror=undef
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes