update to use the config package to configure tracer provider #9967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9967 +/- ##
==========================================
+ Coverage 91.71% 91.75% +0.03%
==========================================
Files 359 358 -1
Lines 16642 16535 -107
==========================================
- Hits 15263 15171 -92
+ Misses 1054 1041 -13
+ Partials 325 323 -2 ☔ View full report in Codecov by Sentry. |
mx-psi
approved these changes
Apr 16, 2024
| // TODO: once https://github.com/open-telemetry/opentelemetry-configuration/issues/83 is resolved, | ||
| // configuration for sampler should be done here via something like the following: | ||
| // | ||
| // Sampler: &config.Sampler{ |
There was a problem hiding this comment.
After merging this PR and before resolving open-telemetry/opentelemetry-configuration/issues/83 we would have no sampling? (That's okay with me, just double checking)
There was a problem hiding this comment.
By default the parent based sampler with always sample is configured:
|
Needs tidying |
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/use-config-sdk
branch
from
914a886 to
d0904ce
Compare
Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the functionality to use the OTel Go Contrib package to configure the SDK for Tracer Providers.
Fixes #9715