[exporterhelper] Fix persistent queue size backup on reads #9740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Persistent queue size backup on reads should depend on readIndex, not writeIndex.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9740 +/- ##
=======================================
Coverage 90.98% 90.98%
=======================================
Files 349 349
Lines 18572 18572
=======================================
Hits 16897 16897
Misses 1348 1348
Partials 327 327 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@carsonip nice find. Can you add a test that covers this situation?
dmitryax
approved these changes
Mar 12, 2024
|
Thank you! @TylerHelmuth a test to catch this might be too complicated. Given that this code path covers a very narrow edge case and is only beneficial for use cases when the collector is killed, I think it's ok to merge as is |
tomasmota
pushed a commit
to tomasmota/opentelemetry-collector
that referenced
this pull request
Mar 14, 2024
…metry#9740) **Description:** Persistent queue size backup on reads should depend on readIndex, not writeIndex.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Persistent queue size backup on reads should depend on readIndex, not
writeIndex.