Skip to content

Conversation

@TylerHelmuth
Copy link
Member

Description:
Fixes a bug where Get was not thread safe.

Link to tracking Issue:
Closes #9594

Testing:
Tested locally

@TylerHelmuth TylerHelmuth requested review from a team and codeboten February 16, 2024 20:31
@dmitryax
Copy link
Member

@TylerHelmuth PTAL at the failing tests

@codecov
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df96393) 90.69% compared to head (0576a00) 90.70%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9595      +/-   ##
==========================================
+ Coverage   90.69%   90.70%   +0.01%     
==========================================
  Files         347      347              
  Lines       18211    18210       -1     
==========================================
+ Hits        16516    16518       +2     
+ Misses       1371     1369       -2     
+ Partials      324      323       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth
Copy link
Member Author

@jpkrohling please also take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[client] Metadata is not thread safe

3 participants