Skip to content

Conversation

@bogdandrutu
Copy link
Member

Fixes #347

@codecov-io
Copy link

codecov-io commented May 2, 2020

Codecov Report

Merging #909 into master will decrease coverage by 0.15%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   85.12%   84.96%   -0.16%     
==========================================
  Files         174      174              
  Lines       13376    13341      -35     
==========================================
- Hits        11386    11335      -51     
- Misses       1543     1552       +9     
- Partials      447      454       +7     
Impacted Files Coverage Δ
config/configmodels/configmodels.go 95.00% <ø> (-0.84%) ⬇️
config/example_factories.go 84.84% <ø> (+0.17%) ⬆️
receiver/jaegerreceiver/config.go 100.00% <ø> (ø)
receiver/otlpreceiver/factory.go 94.87% <ø> (-0.13%) ⬇️
receiver/jaegerreceiver/factory.go 93.38% <80.00%> (ø)
translator/trace/jaeger/traces_to_jaegerproto.go 79.75% <88.88%> (-0.06%) ⬇️
config/config.go 96.26% <89.47%> (-3.49%) ⬇️
translator/internaldata/resource_to_oc.go 76.47% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b2d65...91f7e35. Read the comment docs.

Copy link
Contributor

@rghetia rghetia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor nits. otherwise LGTM.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Don't have context why it was needed before tho.

@bogdandrutu bogdandrutu merged commit 5d1aacc into open-telemetry:master May 3, 2020
@bogdandrutu bogdandrutu deleted the disabled branch May 3, 2020 15:10
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…-telemetry#909)

* Add semantic convention for faas coldstart and container ID

* Update Changelog

Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove disable/enable from components

4 participants