Remove unnecessary condition to have at least one processor #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
artificalcond
branch
from
bb25255 to
4048efc
Compare
owais
approved these changes
Mar 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
==========================================
- Coverage 84.58% 84.58% -0.01%
==========================================
Files 162 162
Lines 11653 11650 -3
==========================================
- Hits 9857 9854 -3
Misses 1394 1394
Partials 402 402
Continue to review full report at Codecov.
|
annanay25
reviewed
Mar 30, 2020
| {name: "pipeline-must-have-receiver", expected: errPipelineMustHaveReceiver}, | ||
| {name: "pipeline-exporter-not-exists", expected: errPipelineExporterNotExists}, | ||
| {name: "pipeline-processor-not-exists", expected: errPipelineProcessorNotExists}, | ||
| {name: "pipeline-must-have-processors", expected: errPipelineMustHaveProcessors}, |
There was a problem hiding this comment.
This test should be replaced with "pipeline-with-zero-processors" that should give no error.
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
The processor is needed for grouping flat logs attributes coming from fluentd to reduce the logs payload and be able to apply k8s metadata enrichment based on "k8s.pod.uid" resource attribute
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
…es and pod annotations/labels (open-telemetry#744) Within our values files we have some templating requirements where it would be nice to be able to template the host fields of an ingress and labels/annotations of the pods. This is a small change to add a tpl call to each of the references. --------- Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes testing the collector locally harder. Also the condition is not enforced because having a disabled processor in the pipeline passes that condition which makes it not very useful.