Skip to content

Fix null pointer exception in the logging exporter #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2020
Merged

Fix null pointer exception in the logging exporter #743

merged 2 commits into from
Mar 30, 2020

Conversation

@bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Mar 30, 2020

No description provided.

@bogdandrutu
Copy link
Member Author

bogdandrutu commented Mar 30, 2020

Thanks @owais

@bogdandrutu bogdandrutu merged commit 9aa2386 into open-telemetry:master Mar 30, 2020
@bogdandrutu bogdandrutu deleted the fixlogging branch March 30, 2020 03:07
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
@jmacd
Disable parts of batch_span_processor test as flakes (open-telemetry#743
055e9c5 
)

* Name the BSP tests

* Add a drain wait group; use the stop wait group to avoid leaking a goroutine

* Lint & comments

* Fix

* Use defer/recover

* Restore the Add/Done...

* Restore the Add/Done...

* Consolidate select stmts

* Disable the test

* Lint

* Use better recover
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
@maxgolov
Add curl via vcpkg to WIndows builds (open-telemetry#743)
834bba6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flands flands Awaiting requested review from flands

@pjanotti pjanotti Awaiting requested review from pjanotti

@rghetia rghetia Awaiting requested review from rghetia

@songy23 songy23 Awaiting requested review from songy23

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

1 more reviewer

@owais owais owais approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bogdandrutu @owais