-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Propagate Remote Sampling Host port correctly #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Joe Elliott <[email protected]>
|
Hi @joe-elliott - is it the idea that this parameter is going to always be required? |
|
Yup. When Annanay added the remote sampling proxy functionality he forgot to add a way to configure the listening port. This PR amends that. Without this field remote sampling does not work. |
|
Aha, I assumed that remote sampling would be served over the http proxy be default. |
Signed-off-by: Joe Elliott <[email protected]>
|
@pjanotti |
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
==========================================
- Coverage 76.04% 76.04% -0.01%
==========================================
Files 123 123
Lines 7627 7634 +7
==========================================
+ Hits 5800 5805 +5
- Misses 1552 1553 +1
- Partials 275 276 +1
Continue to review full report at Codecov.
|
pjanotti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joe-elliott! LGTM
|
Thanks! |
* Release v0.29.0 * fixes * Change the map type in expandStringValues (open-telemetry#507) * fix smartagent receiver/extension config * Update CHANGELOG.md Co-authored-by: Jay Camp <[email protected]> Co-authored-by: Paulo Janotti <[email protected]>
Added propagation code/tests.
Fixes #492
cc @annanay25