Jaeger receiver: Remote sampling support #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
annanay25
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
joe-elliott
reviewed
Dec 6, 2019
joe-elliott
reviewed
Dec 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 75.72% 75.73% +0.01%
==========================================
Files 120 120
Lines 7345 7357 +12
==========================================
+ Hits 5562 5572 +10
- Misses 1520 1521 +1
- Partials 263 264 +1
Continue to review full report at Codecov.
|
joe-elliott
reviewed
Dec 6, 2019
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Contributor
Author
|
@open-telemetry/collector-maintainers - Please review. |
pjanotti
approved these changes
Dec 10, 2019
Contributor
pjanotti
left a comment
pjanotti
left a comment
There was a problem hiding this comment.
@annanay25 LGTM just a few Qs and a nit
Co-Authored-By: Tigran Najaryan <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
tigrannajaryan
approved these changes
Dec 17, 2019
Member
|
Thanks @annanay25 |
Contributor
Author
|
Thanks! |
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.6+incompatible to 20.10.7+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md) - [Commits](moby/moby@v20.10.6...v20.10.7) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes over from #432
jReceiverstructremote_sampling:fetch_endpoint)/cc @joe-elliott @tigrannajaryan