all: remove OtlpProtoSize in favor of Sizer interface #3818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Aug 11, 2021
Contributor
|
Does this PR replace this other one? #3692, and if so, can that one be closed? |
kirbyquerby
commented
Aug 11, 2021
Member
Author
kirbyquerby
left a comment
kirbyquerby
left a comment
There was a problem hiding this comment.
Thanks for taking a look, Bogdan! I've updated based on your comments, please take another look and if it looks good, I can write tests and send this as an actual PR.
bogdandrutu
reviewed
Aug 11, 2021
Member
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
I think this got to a good shape and can be marked as ready for review.
bogdandrutu
reviewed
Aug 11, 2021
6 tasks
Aneurysm9
reviewed
Aug 12, 2021
bogdandrutu
approved these changes
Aug 17, 2021
tbarker25
pushed a commit
to tbarker25/opentelemetry-collector
that referenced
this pull request
Aug 20, 2021
…#3818) * all: remove OtlpProtoSize in favor of Sizer interface * add {Metrics|Traces|Logs}Sizer, fix test commenting * move size tests to pb_test, fix metrics+logs parameter names * uncommented batch_processor tests + adjusted them to use *Sizer * I forgot BenchmarkTraceSizeBytes :( * Add docs for NewProtobof*Sizer + update docs for NewProtobuf*Marshaler * cast *Marshaler to *Sizer for now * add casts to batch_processor_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: remove OtlpProtoSize in favor of Sizer interface.
This change adds a
Sizerinterface + an implementation forpb_marshaleras per the discussion in #3531. This allows us to removeOtlpProtoSize()from traces/metrics/logs and will allow different marshalers to implementSize()themselves.Link to tracking Issue: Fixes #3531
Testing: Moved size tests for traces/metrics/logs to
pb_marshalerand convertedbatch_processor_testto use the *Sizers frompb_marshaler