Standarize Settings, Params and Parameters in Receiver #3167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
pmatyjasek-sumo
force-pushed
the
pm_standarize_settings_receivers
branch
from
ba163ec to
f78a9e3
Compare
| assert.Equal(t, &nopReceiverConfig{ReceiverSettings: config.NewReceiverSettings(config.NewID("nop"))}, cfg) | ||
|
|
||
| traces, err := factory.CreateTracesReceiver(context.Background(), component.ReceiverCreateParams{}, cfg, consumertest.NewNop()) | ||
| traces, err := factory.CreateTracesReceiver(context.Background(), component.ReceiverCreateSettings{}, cfg, consumertest.NewNop()) |
There was a problem hiding this comment.
Just as the other test, it may be useful to have a nop instance. Not a biggie though.
There was a problem hiding this comment.
Sure, but I didn't want to change any logic there. Only refactor the code
carlosalberto
approved these changes
May 24, 2021
pmatyjasek-sumo
force-pushed
the
pm_standarize_settings_receivers
branch
from
f78a9e3 to
aa553d7
Compare
|
Lint errors |
pmatyjasek-sumo
force-pushed
the
pm_standarize_settings_receivers
branch
from
aa553d7 to
b777fc7
Compare
|
Failing tests not fixed. |
pmatyjasek-sumo
force-pushed
the
pm_standarize_settings_receivers
branch
from
b777fc7 to
e506652
Compare
|
Rebased and tests fixed |
|
Sorry, merged another one of our PRs and a rebase is needed again :) |
|
ok :) I'll do it again |
Replace all dependencies in Receivers. Signed-off-by: Patryk Matyjasek <[email protected]> # Conflicts: # component/receiver.go # Conflicts: # exporter/opencensusexporter/opencensus_test.go # exporter/prometheusexporter/end_to_end_test.go
Signed-off-by: Patryk Matyjasek <[email protected]> # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md
Signed-off-by: Patryk Matyjasek <[email protected]>
pmatyjasek-sumo
force-pushed
the
pm_standarize_settings_receivers
branch
from
e506652 to
585d38f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Continuation work from #2991
Fixes #2650
Replace ReceiverCreateParams with ReceiverCreateSettings.
Replace all dependencies in Receivers.
Link to tracking Issue:
#2650
Testing:
Unit tests
Documentation: