Add resource_to_telemetry_conversion config in prometheusremotewriteexp #3031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
bogdandrutu
approved these changes
Apr 28, 2021
Member
|
Please rebase to pick the latest correctness checks |
Member
|
Ping @mxiamxia |
mxiamxia
force-pushed
the
amp_resource_attrs
branch
from
b3fd5f5 to
edd3359
Compare
Member
Author
Yep. the new one picked it up. ty! |
mxiamxia
force-pushed
the
amp_resource_attrs
branch
from
edd3359 to
269e791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add
exporterhelper.ResourceToTelemetrySettingssupport inprometheusremotewriteexporterconfig. It will allow bothprometheusremotewriteexporterandampprometheusremotewriteexporterbe able to convert Resource attributes to Metric Labels for Prometheus metrics.Link to tracking Issue:
aws-observability/aws-otel-collector#472
Testing:
make all