Use confignet.TCPAddr in extentions #2829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change pprof and zpages extentions' configs to use confignet.TCPAddr struct instead of `Endpoint` string. Signed-off-by: Daniil Rutskiy <[email protected]>
Signed-off-by: Daniil Rutskiy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2829 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 281 281
Lines 15131 15135 +4
=======================================
+ Hits 13886 13890 +4
Misses 852 852
Partials 393 393
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change
pprofandzpagesextensions' configs to useconfignet.TCPAddrinstead ofEndpointstring.Link to tracking Issue: #2764