Skip to content

Conversation

@sankala-dremio
Copy link
Contributor

Description:
Fixing a bug - PrometheusReceiver ignores Summary and Histogram Metrics that do not have _sum counter. #2661

Modified the condition in toDistributionTimeSeries and toSummaryTimeSeries functions to ignore the hasSum check.

Link to tracking Issue:
#2661

Testing:
Updated Unit test cases, and also tested with live application using DropWizard metrics framework.

Documentation:
None.

Please delete paragraphs that you did not use before submitting.

@sankala-dremio sankala-dremio requested a review from a team March 26, 2021 04:10
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #2812 (26e70a0) into main (e3c5965) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2812   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         293      293           
  Lines       15635    15635           
=======================================
  Hits        14333    14333           
  Misses        891      891           
  Partials      411      411           
Impacted Files Coverage Δ
...ceiver/prometheusreceiver/internal/metricfamily.go 98.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c5965...26e70a0. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants