Change Zipkin receiver to not use internal data #2699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2699 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 290 290
Lines 15559 15559
=======================================
Hits 14285 14285
Misses 876 876
Partials 398 398 Continue to review full report at Codecov.
|
carlosalberto
approved these changes
Mar 15, 2021
jcchavezs
reviewed
Mar 16, 2021
| span1.SetSpanID(pdata.NewSpanID([8]byte{0x67, 0x66, 0x65, 0x64, 0x63, 0x62, 0x61, 0x60})) | ||
| span1.SetParentSpanID(pdata.NewSpanID([8]byte{0x17, 0x16, 0x15, 0x14, 0x13, 0x12, 0x11, 0x10})) | ||
| span1.SetName("CacheWarmUp") | ||
| span1.SetStartTime(pdata.TimestampFromTime(now.Add(-10 * time.Hour))) |
There was a problem hiding this comment.
small nit: shall we use deterministic values instead of changing this value on every test? IT might not affect the test but just to be consistent.
There was a problem hiding this comment.
I didn't touch that code :). But I fully agree with you.
tigrannajaryan
approved these changes
Mar 16, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…elemetry#2699) Bumps [setuptools](https://github.com/pypa/setuptools) from 65.6.3 to 67.6.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst) - [Commits](pypa/setuptools@v65.6.3...v67.6.0) --- updated-dependencies: - dependency-name: setuptools dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu [email protected]