Skip to content

[pdata/pprofile] fix off-by one Dictionary issue#14534

Merged
mx-psi merged 1 commit intoopen-telemetry:mainfrom
florianl:pprofile-off-by-one
Feb 5, 2026
Merged

[pdata/pprofile] fix off-by one Dictionary issue#14534
mx-psi merged 1 commit intoopen-telemetry:mainfrom
florianl:pprofile-off-by-one

Conversation

@florianl
Copy link
Member

@florianl florianl commented Feb 5, 2026

Description

Fix off-by-one issue in dictionary lookups.

Link to tracking issue

Fixes #

Testing

Documentation

@florianl florianl requested review from a team, dmathieu and mx-psi as code owners February 5, 2026 07:48
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl force-pushed the pprofile-off-by-one branch from 1744d38 to a4cbe78 Compare February 5, 2026 07:52
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.83%. Comparing base (b6dccff) to head (a4cbe78).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14534      +/-   ##
==========================================
- Coverage   91.86%   91.83%   -0.04%     
==========================================
  Files         677      677              
  Lines       42724    42724              
==========================================
- Hits        39247    39234      -13     
- Misses       2424     2433       +9     
- Partials     1053     1057       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu added the ready-to-merge Code review completed; ready to merge by maintainers label Feb 5, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 5, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing florianl:pprofile-off-by-one (a4cbe78) with main (b6dccff)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 61 untouched benchmarks
⏩ 20 skipped benchmarks1

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@mx-psi mx-psi added this pull request to the merge queue Feb 5, 2026
Merged via the queue into open-telemetry:main with commit a270e08 Feb 5, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants