Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (63.29%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #14530 +/- ##
==========================================
- Coverage 91.83% 91.76% -0.07%
==========================================
Files 677 678 +1
Lines 42719 42817 +98
==========================================
+ Hits 39230 39292 +62
- Misses 2432 2452 +20
- Partials 1057 1073 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ArthurSens
left a comment
There was a problem hiding this comment.
That's a decent start :)
As inspiration, Kubebuilder's Makefile provides a good example of a good developer experience.
CodSpeed Performance ReportMerging this PR will improve performance by 38.72%Comparing
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | BenchmarkMetricsMarshalJSON |
5.5 µs | 3.9 µs | +38.72% |
| ⚡ | BenchmarkLogsMarshalJSON |
3.8 µs | 3 µs | +28.48% |
| ⚡ | BenchmarkTracesMarshalJSON |
6 µs | 4.6 µs | +28.89% |
Footnotes
-
20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
Some future work I'd love to see here is adding commands like
that would generate the scaffolding for a new component with all the necessary initial files and go structure, like factories, empty config struct, metadata.yaml, etc etc :) CI, renovate config and all the goodness we use to maintain our own repositories would be good additions too |
|
The only thing I still want to add is a |
Co-authored-by: Arthur Silva Sens <[email protected]>
|
cc @mx-psi @jpkrohling this is the |
ArthurSens
left a comment
There was a problem hiding this comment.
By the way, happy to be code owner and help evolve and maintain ocb :)
In case the current code owners would be ok with it of course
|
I'd be happy to be added as codeowner as well. |
Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
|
Can you file a separate PR to be added as codeowners @ArthurSens @dmathieu ? |
|
Will merge this on Monday unless there are further comments |
florianl
left a comment
There was a problem hiding this comment.
I love this approach making it easier to adapt OCB 🚀
This follows #14530 cc @ArthurSens
f5333c7
This introduces a new
ocb initcommand which is meant to setup a new custom collector repository.The intent for this new subcommand at the moment is to be rather simple.
We discussed the potential of making it more powerful with things such as
--from-configthat would initialize the manifest from an existing collector config.In order to keep things reviewable, we'll do this in iterations.