Skip to content

OCB init#14530

Merged
mx-psi merged 28 commits intoopen-telemetry:mainfrom
dmathieu:ocb-init
Feb 9, 2026
Merged

OCB init#14530
mx-psi merged 28 commits intoopen-telemetry:mainfrom
dmathieu:ocb-init

Conversation

@dmathieu
Copy link
Member

@dmathieu dmathieu commented Feb 4, 2026

This introduces a new ocb init command which is meant to setup a new custom collector repository.

The intent for this new subcommand at the moment is to be rather simple.
We discussed the potential of making it more powerful with things such as --from-config that would initialize the manifest from an existing collector config.
In order to keep things reviewable, we'll do this in iterations.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 63.29114% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.76%. Comparing base (5e3bf40) to head (158e808).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
cmd/builder/internal/command_init.go 59.15% 15 Missing and 14 partials ⚠️

❌ Your patch status has failed because the patch coverage (63.29%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14530      +/-   ##
==========================================
- Coverage   91.83%   91.76%   -0.07%     
==========================================
  Files         677      678       +1     
  Lines       42719    42817      +98     
==========================================
+ Hits        39230    39292      +62     
- Misses       2432     2452      +20     
- Partials     1057     1073      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a decent start :)

As inspiration, Kubebuilder's Makefile provides a good example of a good developer experience.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 5, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 38.72%

Comparing dmathieu:ocb-init (158e808) with main (81bc641)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 3 improved benchmarks
✅ 58 untouched benchmarks
⏩ 20 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
BenchmarkMetricsMarshalJSON 5.5 µs 3.9 µs +38.72%
BenchmarkLogsMarshalJSON 3.8 µs 3 µs +28.48%
BenchmarkTracesMarshalJSON 6 µs 4.6 µs +28.89%

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where you wanna go before calling this PR complete. I'm super happy to see this getting merged and we iterate together over time :)

@ArthurSens
Copy link
Member

ArthurSens commented Feb 5, 2026

Some future work I'd love to see here is adding commands like

ocb create receiver <name> --signals=metrics,traces,logs,profiles
ocb create processor <name> --signals=metrics,traces,logs,profiles
ocb create extension <name> --signals=metrics,traces,logs,profiles
ocb create exporter <name> --signals=metrics,traces,logs,profiles

that would generate the scaffolding for a new component with all the necessary initial files and go structure, like factories, empty config struct, metadata.yaml, etc etc :)

CI, renovate config and all the goodness we use to maintain our own repositories would be good additions too

@dmathieu
Copy link
Member Author

dmathieu commented Feb 5, 2026

The only thing I still want to add is a README.md.

@dmathieu dmathieu marked this pull request as ready for review February 6, 2026 09:04
@dmathieu dmathieu requested a review from a team as a code owner February 6, 2026 09:04
@dmathieu dmathieu requested a review from evan-bradley February 6, 2026 09:04
@dmathieu
Copy link
Member Author

dmathieu commented Feb 6, 2026

cc @mx-psi @jpkrohling this is the ocb init command we discussed on monday.

Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, happy to be code owner and help evolve and maintain ocb :)

In case the current code owners would be ok with it of course

@dmathieu
Copy link
Member Author

dmathieu commented Feb 6, 2026

I'd be happy to be added as codeowner as well.

@mx-psi
Copy link
Member

mx-psi commented Feb 6, 2026

Can you file a separate PR to be added as codeowners @ArthurSens @dmathieu ?

@mx-psi
Copy link
Member

mx-psi commented Feb 6, 2026

Will merge this on Monday unless there are further comments

Copy link
Member

@florianl florianl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this approach making it easier to adapt OCB 🚀

github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2026
@mx-psi mx-psi added this pull request to the merge queue Feb 9, 2026
Merged via the queue into open-telemetry:main with commit f5333c7 Feb 9, 2026
62 of 63 checks passed
zeekay pushed a commit to hanzoai/telemetry that referenced this pull request Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants