Skip to content

[config/confighttp] Fix high cardinality span name from request method from confighttp server internal telemetry#14522

Merged
mx-psi merged 7 commits intoopen-telemetry:mainfrom
elastic:confighttp-span-name-method
Feb 4, 2026
Merged

[config/confighttp] Fix high cardinality span name from request method from confighttp server internal telemetry#14522
mx-psi merged 7 commits intoopen-telemetry:mainfrom
elastic:confighttp-span-name-method

Conversation

@carsonip
Copy link
Copy Markdown
Contributor

@carsonip carsonip commented Feb 3, 2026

Description

Bound cardinality from request method in span name by passing thorugh upper case request method only if well known, otherwise set {method} to HTTP.

Implemented according to https://opentelemetry.io/docs/specs/semconv/http/http-spans/

Link to tracking issue

Fixes #14516

Testing

Unit test for unknown method and lowercase method.

Documentation

@carsonip carsonip requested a review from a team as a code owner February 3, 2026 12:05
@carsonip carsonip requested a review from axw February 3, 2026 12:05
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.84%. Comparing base (cce7dc1) to head (281bdf8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14522      +/-   ##
==========================================
- Coverage   91.85%   91.84%   -0.01%     
==========================================
  Files         677      677              
  Lines       42705    42712       +7     
==========================================
+ Hits        39226    39230       +4     
- Misses       2425     2427       +2     
- Partials     1054     1055       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 3, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing elastic:confighttp-span-name-method (281bdf8) with main (cce7dc1)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 61 untouched benchmarks
⏩ 20 skipped benchmarks1

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Copy Markdown
Contributor

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@axw axw added the ready-to-merge Code review completed; ready to merge by maintainers label Feb 4, 2026
@mx-psi mx-psi added this pull request to the merge queue Feb 4, 2026
Merged via the queue into open-telemetry:main with commit 3c135df Feb 4, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[config/confighttp] High cardinality request method from internal telemetry traces

4 participants