Skip to content

[xconnector] Add component ID type validation to factory methods#14357

Merged
dmitryax merged 1 commit intoopen-telemetry:mainfrom
dmitryax:add-missing-checks
Jan 6, 2026
Merged

[xconnector] Add component ID type validation to factory methods#14357
dmitryax merged 1 commit intoopen-telemetry:mainfrom
dmitryax:add-missing-checks

Conversation

@dmitryax
Copy link
Copy Markdown
Member

@dmitryax dmitryax commented Jan 5, 2026

Adds component ID type validation to all xconnector Create methods to match the pattern used in the all other factories. The checks were missed in #12381

@dmitryax dmitryax requested review from a team, dmathieu and mx-psi as code owners January 5, 2026 23:23
@dmitryax dmitryax force-pushed the add-missing-checks branch 3 times, most recently from 396ef61 to 934d7bf Compare January 6, 2026 00:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.10%. Comparing base (ee8646e) to head (06f9284).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14357      +/-   ##
==========================================
+ Coverage   92.09%   92.10%   +0.01%     
==========================================
  Files         668      668              
  Lines       41363    41377      +14     
==========================================
+ Hits        38092    38112      +20     
+ Misses       2231     2227       -4     
+ Partials     1040     1038       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmitryax dmitryax force-pushed the add-missing-checks branch from 934d7bf to 22d1e92 Compare January 6, 2026 03:24
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 6, 2026

CodSpeed Performance Report

Merging #14357 will degrade performance by 31.53%

Comparing dmitryax:add-missing-checks (06f9284) with main (ee8646e)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 4 regressions
✅ 55 untouched
⏩ 20 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
BenchmarkTraceSizeBytes 299.8 µs 437.8 µs -31.53%
BenchmarkProfilesToProto 1.2 µs 1.7 µs -27.01%
BenchmarkLogsToProto2k 44.7 µs 63.2 µs -29.25%
BenchmarkTracesToProto2k 69.9 µs 96 µs -27.15%

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Adds component ID type validation to all xconnector Create methods to match the pattern used in the all other factories. The checks were missed in open-telemetry#12381
@dmitryax dmitryax added this pull request to the merge queue Jan 6, 2026
Merged via the queue into open-telemetry:main with commit 58db72d Jan 6, 2026
61 of 62 checks passed
@dmitryax dmitryax deleted the add-missing-checks branch January 6, 2026 10:01
sivchari pushed a commit to sivchari/opentelemetry-collector that referenced this pull request Jan 7, 2026
…n-telemetry#14357)

Adds component ID type validation to all xconnector Create methods to
match the pattern used in the all other factories. The checks were
missed in
open-telemetry#12381
Syedowais312 pushed a commit to Syedowais312/opentelemetry-collector that referenced this pull request Jan 14, 2026
…n-telemetry#14357)

Adds component ID type validation to all xconnector Create methods to
match the pattern used in the all other factories. The checks were
missed in
open-telemetry#12381
Syedowais312 pushed a commit to Syedowais312/opentelemetry-collector that referenced this pull request Jan 15, 2026
…n-telemetry#14357)

Adds component ID type validation to all xconnector Create methods to
match the pattern used in the all other factories. The checks were
missed in
open-telemetry#12381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants