[xconnector] Add component ID type validation to factory methods#14357
[xconnector] Add component ID type validation to factory methods#14357dmitryax merged 1 commit intoopen-telemetry:mainfrom
Conversation
396ef61 to
934d7bf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14357 +/- ##
==========================================
+ Coverage 92.09% 92.10% +0.01%
==========================================
Files 668 668
Lines 41363 41377 +14
==========================================
+ Hits 38092 38112 +20
+ Misses 2231 2227 -4
+ Partials 1040 1038 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
934d7bf to
22d1e92
Compare
CodSpeed Performance ReportMerging #14357 will degrade performance by 31.53%Comparing
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | BenchmarkTraceSizeBytes |
299.8 µs | 437.8 µs | -31.53% |
| ❌ | BenchmarkProfilesToProto |
1.2 µs | 1.7 µs | -27.01% |
| ❌ | BenchmarkLogsToProto2k |
44.7 µs | 63.2 µs | -29.25% |
| ❌ | BenchmarkTracesToProto2k |
69.9 µs | 96 µs | -27.15% |
Footnotes
-
20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Adds component ID type validation to all xconnector Create methods to match the pattern used in the all other factories. The checks were missed in open-telemetry#12381
22d1e92 to
06f9284
Compare
58db72d
…n-telemetry#14357) Adds component ID type validation to all xconnector Create methods to match the pattern used in the all other factories. The checks were missed in open-telemetry#12381
…n-telemetry#14357) Adds component ID type validation to all xconnector Create methods to match the pattern used in the all other factories. The checks were missed in open-telemetry#12381
…n-telemetry#14357) Adds component ID type validation to all xconnector Create methods to match the pattern used in the all other factories. The checks were missed in open-telemetry#12381
Adds component ID type validation to all xconnector Create methods to match the pattern used in the all other factories. The checks were missed in #12381