Add disk.pending_operations metric #1428
Conversation
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
|
Note Windows also has an "Avg. Disk Queue Length" counter but that is actually just an estimate based on other stats as described here: https://www.sciencedirect.com/topics/computer-science/disk-queue-length Given the slightly strange way that is calculated, and to be consistent with the point-in-time value returned by Linux, I've opted to use "Current Disk Queue Length" over "Avg. Disk Queue Length". |
james-bebbington
force-pushed
the
disk-pending
branch
from
2dcdefc to
2839784
Compare
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
==========================================
+ Coverage 90.30% 90.33% +0.02%
==========================================
Files 232 232
Lines 16396 16418 +22
==========================================
+ Hits 14807 14831 +24
+ Misses 1134 1133 -1
+ Partials 455 454 -1
Continue to review full report at Codecov.
|
| "system.disk.ops", | ||
| "system.disk.pending_operations", |
There was a problem hiding this comment.
Should we unabbreviate ops in other metrics?
There was a problem hiding this comment.
Yes the OTEP recently changed these to long names. I will update names again in a follow up PR
…pen-telemetry#1428) * adding codeql workfklow * removing PR and commit triggers * updating changelog * removing push trigger Co-authored-by: Azfaar Qureshi <[email protected]>
3 participants
Adds
disk.pending_operationsmetric.On Windows this is the "Current disk queue length", obtained via a perf counter whereas on Linux this is the "I/Os currently in progress" value returned by procfs/disktats.