[xscraperhelper] init package#14235
Conversation
Signed-off-by: Florian Lehner <[email protected]>
9b26e18 to
2ed498e
Compare
Signed-off-by: Florian Lehner <[email protected]>
Merging this PR will not alter performance
|
Signed-off-by: Florian Lehner <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14235 +/- ##
==========================================
+ Coverage 92.21% 92.23% +0.02%
==========================================
Files 670 676 +6
Lines 41472 41641 +169
==========================================
+ Hits 38242 38407 +165
- Misses 2193 2196 +3
- Partials 1037 1038 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
|
It looks like xscraperhelper duplicates a lot of code from scraperhelper, which is probably why the PR is so large. This is not ideal, since it makes maintenance a lot more difficult (any change in scraperhelper would have to be copied over to xscraperhelper). I think a better approach would be to move the "generic" components used in all signals into |
Signed-off-by: Florian Lehner <[email protected]>
|
@jade-guiton-dd with 92bc761 I have started to deduplicate code. But the win of deduplication is limited. While it seems that a good portion of code is duplicate, they differ in essential elements, like |
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
jade-guiton-dd
left a comment
There was a problem hiding this comment.
I think this looks good, just one more issue.
I'll ask if another maintainer can take a look.
Signed-off-by: Florian Lehner <[email protected]>
jade-guiton-dd
left a comment
There was a problem hiding this comment.
LGTM. I'd like a second approval on this before merging however, since it's a fairly large PR.
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
#### Description Along with `scraper/xscraper` this package is needed to enable OTel Profiling signal receivers, such as [receiver/pprofreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver). #### Link to tracking issue Fixes # <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Florian Lehner <[email protected]> Signed-off-by: Florian Lehner <[email protected]>
#### Description Along with `scraper/xscraper` this package is needed to enable OTel Profiling signal receivers, such as [receiver/pprofreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver). #### Link to tracking issue Fixes # <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Florian Lehner <[email protected]> Signed-off-by: Florian Lehner <[email protected]>
Description
Along with
scraper/xscraperthis package is needed to enable OTel Profiling signal receivers, such as receiver/pprofreceiver.Link to tracking issue
Fixes #
Testing
Documentation