Skip to content

[xscraperhelper] init package#14235

Merged
mx-psi merged 52 commits intoopen-telemetry:mainfrom
florianl:xscraperhelper
Jan 9, 2026
Merged

[xscraperhelper] init package#14235
mx-psi merged 52 commits intoopen-telemetry:mainfrom
florianl:xscraperhelper

Conversation

@florianl
Copy link
Member

@florianl florianl commented Dec 1, 2025

Description

Along with scraper/xscraper this package is needed to enable OTel Profiling signal receivers, such as receiver/pprofreceiver.

Link to tracking issue

Fixes #

Testing

Documentation

Signed-off-by: Florian Lehner <[email protected]>
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 1, 2025

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 62 untouched benchmarks
⏩ 20 skipped benchmarks1


Comparing florianl:xscraperhelper (5f888fd) with main (4db9157)

Open in CodSpeed

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Florian Lehner <[email protected]>
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 97.16599% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.23%. Comparing base (4db9157) to head (5f888fd).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...er/scraperhelper/internal/controller/controller.go 95.00% 2 Missing and 1 partial ⚠️
...craper/scraperhelper/internal/testhelper/helper.go 94.44% 2 Missing ⚠️
...perhelper/internal/metadata/generated_telemetry.go 93.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14235      +/-   ##
==========================================
+ Coverage   92.21%   92.23%   +0.02%     
==========================================
  Files         670      676       +6     
  Lines       41472    41641     +169     
==========================================
+ Hits        38242    38407     +165     
- Misses       2193     2196       +3     
- Partials     1037     1038       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
@florianl florianl marked this pull request as ready for review December 1, 2025 16:20
@florianl florianl requested a review from a team as a code owner December 1, 2025 16:20
@jade-guiton-dd
Copy link
Contributor

It looks like xscraperhelper duplicates a lot of code from scraperhelper, which is probably why the PR is so large. This is not ideal, since it makes maintenance a lot more difficult (any change in scraperhelper would have to be copied over to xscraperhelper). I think a better approach would be to move the "generic" components used in all signals into scraperhelper/internal/xxx packages, so that you can reuse them in scraperhelper/xscraperhelper without duplicating their code.

@florianl
Copy link
Member Author

florianl commented Dec 4, 2025

@jade-guiton-dd with 92bc761 I have started to deduplicate code. But the win of deduplication is limited.

While it seems that a good portion of code is duplicate, they differ in essential elements, like receiver vs xreceiver, consumer vs xconsumer, scraper vs xscraper. Due to these fundamental differences, there seems to be a huge overlapp but it is actually not.

Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, just one more issue.

I'll ask if another maintainer can take a look.

Signed-off-by: Florian Lehner <[email protected]>
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd like a second approval on this before merging however, since it's a fairly large PR.

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jade-guiton-dd jade-guiton-dd added the ready-to-merge Code review completed; ready to merge by maintainers label Dec 12, 2025
@mx-psi mx-psi added this pull request to the merge queue Jan 9, 2026
Merged via the queue into open-telemetry:main with commit 0d3e769 Jan 9, 2026
63 checks passed
Syedowais312 pushed a commit to Syedowais312/opentelemetry-collector that referenced this pull request Jan 14, 2026
#### Description

Along with `scraper/xscraper` this package is needed to enable OTel
Profiling signal receivers, such as
[receiver/pprofreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver).

#### Link to tracking issue
Fixes #

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Syedowais312 pushed a commit to Syedowais312/opentelemetry-collector that referenced this pull request Jan 15, 2026
#### Description

Along with `scraper/xscraper` this package is needed to enable OTel
Profiling signal receivers, such as
[receiver/pprofreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver).

#### Link to tracking issue
Fixes #

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants