[exporter/debug] feat: add dropped* attributes to output#14217
[exporter/debug] feat: add dropped* attributes to output#14217mx-psi merged 7 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14217 +/- ##
==========================================
- Coverage 92.17% 92.16% -0.02%
==========================================
Files 668 668
Lines 41510 41513 +3
==========================================
- Hits 38262 38260 -2
- Misses 2215 2218 +3
- Partials 1033 1035 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrzej-stencel
left a comment
There was a problem hiding this comment.
Thanks @khpeet for this contribution 🙏 I have one suggestion for the ordering, please let me know what you think.
|
Thanks for the review @andrzej-stencel - fixed! |
| buf.logAttr("Status code", span.Status().Code().String()) | ||
| buf.logAttr("Status message", span.Status().Message()) | ||
|
|
||
| buf.logAttr("DroppedAttributesCount", strconv.FormatUint(uint64(span.DroppedAttributesCount()), 10)) |
There was a problem hiding this comment.
This is a bit verbose, I'd rather have buf.logAttr("DroppedAttributesCount", span.DroppedAttributesCount()), but this currently results in funny output like DroppedAttributesCount: %!s(uint32=0). Would be nice to fix the logAttr method in a separate change.
CodSpeed Performance ReportMerging #14217 will not alter performanceComparing
|
Description
Added logging output for:
Link to tracking issue
Fixes #14202
Testing
Added validation output to
two_spans.outandtraces_with_entity_refs.outDocumentation
Added changelog yaml entry summarizing the issue and fix.