Remove UB when taking internal logs and move them to the final zapcore.Core #14009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
fix-buffered-code-ub
branch
2 times, most recently
from
d8071b7 to
e5845d8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14009 +/- ##
=======================================
Coverage 91.66% 91.67%
=======================================
Files 654 654
Lines 42626 42626
=======================================
+ Hits 39072 39076 +4
+ Misses 2741 2738 -3
+ Partials 813 812 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmitryax
approved these changes
Oct 14, 2025
bogdandrutu
force-pushed
the
fix-buffered-code-ub
branch
from
e5845d8 to
29ef1c2
Compare
…e.Core Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
fix-buffered-code-ub
branch
from
29ef1c2 to
8839b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.