Skip to content

[exporter/otlp] fix the validation of unix socket endpoint - #13831

Merged
mx-psi merged 4 commits into
open-telemetry:mainfrom
yumosx:fix-unix-socket
Sep 16, 2025
Merged

[exporter/otlp] fix the validation of unix socket endpoint#13831
mx-psi merged 4 commits into
open-telemetry:mainfrom
yumosx:fix-unix-socket

Conversation

@yumosx

@yumosx yumosx commented Sep 12, 2025

Copy link
Copy Markdown
Member

Description

Unix socket endpoints do not have a host:port structure, so port validation should be skipped to prevent unnecessary errors.

Link to tracking issue

Fixes #13826

@yumosx
yumosx requested a review from a team as a code owner September 12, 2025 17:50
@yumosx
yumosx requested a review from dmathieu September 12, 2025 17:50
@codecov

codecov Bot commented Sep 12, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.41%. Comparing base (4b4e557) to head (c2fcf0e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13831   +/-   ##
=======================================
  Coverage   91.40%   91.41%           
=======================================
  Files         646      646           
  Lines       42606    42612    +6     
=======================================
+ Hits        38945    38954    +9     
+ Misses       2838     2836    -2     
+ Partials      823      822    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@songy23 songy23 added the ready-to-merge Code review completed; ready to merge by maintainers label Sep 15, 2025
@mx-psi
mx-psi added this pull request to the merge queue Sep 15, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 15, 2025
@mx-psi
mx-psi enabled auto-merge September 16, 2025 09:34
@mx-psi
mx-psi added this pull request to the merge queue Sep 16, 2025
Merged via the queue into open-telemetry:main with commit f729e7b Sep 16, 2025
57 checks passed
@github-actions github-actions Bot added this to the next release milestone Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exporter/otlp ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[exporter/otlp] Attempts to parse port from unix socket endpoint and fails

4 participants