Use configoptional for exporterhelper #13345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
a team,
andrzej-stencel,
dmathieu,
dmitryax,
evan-bradley and
mx-psi
as code owners
evan-bradley
reviewed
Jul 7, 2025
jmacd
approved these changes
Jul 7, 2025
dmathieu
approved these changes
Jul 8, 2025
mx-psi
reviewed
Jul 8, 2025
bogdandrutu
force-pushed
the
fix-todo-optional
branch
2 times, most recently
from
e5e7580 to
eaf0f80
Compare
mx-psi
approved these changes
Jul 9, 2025
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (91.66%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13345 +/- ##
==========================================
- Coverage 91.55% 91.53% -0.03%
==========================================
Files 526 526
Lines 29365 29363 -2
==========================================
- Hits 26886 26876 -10
- Misses 1953 1959 +6
- Partials 526 528 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
fix-todo-optional
branch
from
eaf0f80 to
aba35e2
Compare
evan-bradley
approved these changes
Jul 9, 2025
Merged
via the queue into
open-telemetry:main
with commit Jul 9, 2025
12bbddc
47 of 51 checks passed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
…13376) Partially reverts #13345 `configoptional` cannot unmarshal a scalar preset value yet. See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/16199280314/job/45733970146?pr=41234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.