Skip to content

Conversation

@bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jul 3, 2025

Fixes #12890

@bogdandrutu bogdandrutu requested review from a team and dmitryax as code owners July 3, 2025 15:09
@bogdandrutu bogdandrutu force-pushed the persistent-metadata-data branch 3 times, most recently from 253a4c1 to 0aa447e Compare July 3, 2025 18:10
@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 78.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 91.50%. Comparing base (f305ee9) to head (714e373).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../exporterhelper/internal/queue/persistent_queue.go 78.00% 14 Missing and 8 partials ⚠️

❌ Your patch status has failed because the patch coverage (78.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13330      +/-   ##
==========================================
- Coverage   91.61%   91.50%   -0.12%     
==========================================
  Files         526      526              
  Lines       29400    29456      +56     
==========================================
+ Hits        26936    26953      +17     
- Misses       1947     1973      +26     
- Partials      517      530      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu force-pushed the persistent-metadata-data branch from 0aa447e to 6425d00 Compare July 3, 2025 21:29
@dmitryax
Copy link
Member

dmitryax commented Jul 3, 2025

We probably need a changelog item for this change

@bogdandrutu bogdandrutu force-pushed the persistent-metadata-data branch from 6425d00 to 6a5f1c7 Compare July 6, 2025 11:22
@bogdandrutu bogdandrutu enabled auto-merge July 6, 2025 11:24
@bogdandrutu bogdandrutu force-pushed the persistent-metadata-data branch from 6a5f1c7 to 714e373 Compare July 6, 2025 11:24
@bogdandrutu bogdandrutu added this pull request to the merge queue Jul 6, 2025
Merged via the queue into open-telemetry:main with commit e2954b9 Jul 6, 2025
55 of 56 checks passed
@bogdandrutu bogdandrutu deleted the persistent-metadata-data branch July 6, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[exporterhelper] Refactor persistent storage size backup

2 participants