Skip to content

Conversation

@bogdandrutu
Copy link
Member

No description provided.

@dmitryax dmitryax self-requested a review July 13, 2020 18:18
@dmitryax dmitryax self-assigned this Jul 13, 2020
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #1330 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1330      +/-   ##
==========================================
+ Coverage   89.76%   89.95%   +0.19%     
==========================================
  Files         214      214              
  Lines       15138    15167      +29     
==========================================
+ Hits        13589    13644      +55     
+ Misses       1132     1106      -26     
  Partials      417      417              
Impacted Files Coverage Δ
exporter/exportertest/nop_exporter.go 100.00% <100.00%> (+5.26%) ⬆️
exporter/exportertest/sink_exporter.go 100.00% <100.00%> (+28.23%) ⬆️
processor/batchprocessor/batch_processor.go 97.80% <100.00%> (+0.04%) ⬆️
translator/internaldata/resource_to_oc.go 83.72% <0.00%> (-2.33%) ⬇️
translator/internaldata/oc_to_metrics.go 89.10% <0.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab1561...d4fb833. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 29cd959 into open-telemetry:master Jul 13, 2020
@bogdandrutu bogdandrutu deleted the batchp branch July 13, 2020 19:36
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…y#1330)

* Move global code to toplevel package

* Move version function to toplevel package

* Update changelog

Co-authored-by: Tyler Yahn <[email protected]>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
* Read jar file path and service name from a config file

* zc: rename config example file

* zc: dont set default values if the config file is missing

* zc: generate the service name; add readme

* zc: tweak some comments, rename a constant
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants