Skip to content

[service/internal/graph] Add size throughput metrics #13032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

[service/internal/graph] Add size throughput metrics #13032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c37d07
Add size throughput metrics
djaglowski May 13, 2025
ff7fd74
Refactor with Enabled check inside obsconsumer
djaglowski May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .chloggen/pipeline-throughput.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: service

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add size metrics defined in Pipeline Component Telemetry RFC

# One or more tracking issues or pull requests related to the change
issues: [13032]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
See [Pipeline Component Telemetry RFC](https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/component-universal-telemetry.md) for more details:
- `otelcol.receiver.produced.size`
- `otelcol.processor.consumed.size`
- `otelcol.processor.produced.size`
- `otelcol.connector.consumed.size`
- `otelcol.connector.produced.size`
- `otelcol.exporter.consumed.size`

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
44 changes: 24 additions & 20 deletions service/internal/graph/connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func (n *connectorNode) buildTraces(
for _, next := range nexts {
consumers[next.(*capabilitiesNode).pipelineID] = obsconsumer.NewTraces(
next.(consumer.Traces),
tb.ConnectorProducedItems,
tb.ConnectorProducedItems, tb.ConnectorProducedSize,
obsconsumer.WithStaticDataPointAttribute(
otelattr.String(
pipelineIDAttrKey,
Expand All @@ -107,32 +107,33 @@ func (n *connectorNode) buildTraces(
if err != nil {
return err
}

// Connectors which might pass along data must inherit capabilities of all nexts
n.consumer = obsconsumer.NewTraces(
capabilityconsumer.NewTraces(
n.Component.(consumer.Traces),
aggregateCap(n.Component.(consumer.Traces), nexts),
),
tb.ConnectorConsumedItems,
tb.ConnectorConsumedItems, tb.ConnectorConsumedSize,
)
case pipeline.SignalMetrics:
n.Component, err = builder.CreateMetricsToTraces(ctx, set, next)
if err != nil {
return err
}
n.consumer = obsconsumer.NewMetrics(n.Component.(consumer.Metrics), tb.ConnectorConsumedItems)
n.consumer = obsconsumer.NewMetrics(n.Component.(consumer.Metrics), tb.ConnectorConsumedItems, tb.ConnectorConsumedSize)
case pipeline.SignalLogs:
n.Component, err = builder.CreateLogsToTraces(ctx, set, next)
if err != nil {
return err
}
n.consumer = obsconsumer.NewLogs(n.Component.(consumer.Logs), tb.ConnectorConsumedItems)
n.consumer = obsconsumer.NewLogs(n.Component.(consumer.Logs), tb.ConnectorConsumedItems, tb.ConnectorConsumedSize)
case xpipeline.SignalProfiles:
n.Component, err = builder.CreateProfilesToTraces(ctx, set, next)
if err != nil {
return err
}
n.consumer = obsconsumer.NewProfiles(n.Component.(xconsumer.Profiles), tb.ConnectorConsumedItems)
n.consumer = obsconsumer.NewProfiles(n.Component.(xconsumer.Profiles), tb.ConnectorConsumedItems, tb.ConnectorConsumedSize)
}
return nil
}
Expand All @@ -152,7 +153,7 @@ func (n *connectorNode) buildMetrics(
for _, next := range nexts {
consumers[next.(*capabilitiesNode).pipelineID] = obsconsumer.NewMetrics(
next.(consumer.Metrics),
tb.ConnectorProducedItems,
tb.ConnectorProducedItems, tb.ConnectorProducedSize,
obsconsumer.WithStaticDataPointAttribute(
otelattr.String(
pipelineIDAttrKey,
Expand All @@ -169,32 +170,33 @@ func (n *connectorNode) buildMetrics(
if err != nil {
return err
}

// Connectors which might pass along data must inherit capabilities of all nexts
n.consumer = obsconsumer.NewMetrics(
capabilityconsumer.NewMetrics(
n.Component.(consumer.Metrics),
aggregateCap(n.Component.(consumer.Metrics), nexts),
),
tb.ConnectorConsumedItems,
tb.ConnectorConsumedItems, tb.ConnectorConsumedSize,
)
case pipeline.SignalTraces:
n.Component, err = builder.CreateTracesToMetrics(ctx, set, next)
if err != nil {
return err
}
n.consumer = obsconsumer.NewTraces(n.Component.(consumer.Traces), tb.ConnectorConsumedItems)
n.consumer = obsconsumer.NewTraces(n.Component.(consumer.Traces), tb.ConnectorConsumedItems, tb.ConnectorConsumedSize)
case pipeline.SignalLogs:
n.Component, err = builder.CreateLogsToMetrics(ctx, set, next)
if err != nil {
return err
}
n.consumer = obsconsumer.NewLogs(n.Component.(consumer.Logs), tb.ConnectorConsumedItems)
n.consumer = obsconsumer.NewLogs(n.Component.(consumer.Logs), tb.ConnectorConsumedItems, tb.ConnectorConsumedSize)
case xpipeline.SignalProfiles:
n.Component, err = builder.CreateProfilesToMetrics(ctx, set, next)
if err != nil {
return err
}
n.consumer = obsconsumer.NewProfiles(n.Component.(xconsumer.Profiles), tb.ConnectorConsumedItems)
n.consumer = obsconsumer.NewProfiles(n.Component.(xconsumer.Profiles), tb.ConnectorConsumedItems, tb.ConnectorConsumedSize)
}
return nil
}
Expand All @@ -214,7 +216,7 @@ func (n *connectorNode) buildLogs(
for _, next := range nexts {
consumers[next.(*capabilitiesNode).pipelineID] = obsconsumer.NewLogs(
next.(consumer.Logs),
tb.ConnectorProducedItems,
tb.ConnectorProducedItems, tb.ConnectorProducedSize,
obsconsumer.WithStaticDataPointAttribute(
otelattr.String(
pipelineIDAttrKey,
Expand All @@ -231,32 +233,33 @@ func (n *connectorNode) buildLogs(
if err != nil {
return err
}

// Connectors which might pass along data must inherit capabilities of all nexts
n.consumer = obsconsumer.NewLogs(
capabilityconsumer.NewLogs(
n.Component.(consumer.Logs),
aggregateCap(n.Component.(consumer.Logs), nexts),
),
tb.ConnectorConsumedItems,
tb.ConnectorConsumedItems, tb.ConnectorConsumedSize,
)
case pipeline.SignalTraces:
n.Component, err = builder.CreateTracesToLogs(ctx, set, next)
if err != nil {
return err
}
n.consumer = obsconsumer.NewTraces(n.Component.(consumer.Traces), tb.ConnectorConsumedItems)
n.consumer = obsconsumer.NewTraces(n.Component.(consumer.Traces), tb.ConnectorConsumedItems, tb.ConnectorConsumedSize)
case pipeline.SignalMetrics:
n.Component, err = builder.CreateMetricsToLogs(ctx, set, next)
if err != nil {
return err
}
n.consumer = obsconsumer.NewMetrics(n.Component.(consumer.Metrics), tb.ConnectorConsumedItems)
n.consumer = obsconsumer.NewMetrics(n.Component.(consumer.Metrics), tb.ConnectorConsumedItems, tb.ConnectorConsumedSize)
case xpipeline.SignalProfiles:
n.Component, err = builder.CreateProfilesToLogs(ctx, set, next)
if err != nil {
return err
}
n.consumer = obsconsumer.NewProfiles(n.Component.(xconsumer.Profiles), tb.ConnectorConsumedItems)
n.consumer = obsconsumer.NewProfiles(n.Component.(xconsumer.Profiles), tb.ConnectorConsumedItems, tb.ConnectorConsumedSize)
}
return nil
}
Expand All @@ -276,7 +279,7 @@ func (n *connectorNode) buildProfiles(
for _, next := range nexts {
consumers[next.(*capabilitiesNode).pipelineID] = obsconsumer.NewProfiles(
next.(xconsumer.Profiles),
tb.ConnectorProducedItems,
tb.ConnectorProducedItems, tb.ConnectorProducedSize,
obsconsumer.WithStaticDataPointAttribute(
otelattr.String(
pipelineIDAttrKey,
Expand All @@ -293,32 +296,33 @@ func (n *connectorNode) buildProfiles(
if err != nil {
return err
}

// Connectors which might pass along data must inherit capabilities of all nexts
n.consumer = obsconsumer.NewProfiles(
capabilityconsumer.NewProfiles(
n.Component.(xconsumer.Profiles),
aggregateCap(n.Component.(xconsumer.Profiles), nexts),
),
tb.ConnectorConsumedItems,
tb.ConnectorConsumedItems, tb.ConnectorConsumedSize,
)
case pipeline.SignalTraces:
n.Component, err = builder.CreateTracesToProfiles(ctx, set, next)
if err != nil {
return err
}
n.consumer = obsconsumer.NewTraces(n.Component.(consumer.Traces), tb.ConnectorConsumedItems)
n.consumer = obsconsumer.NewTraces(n.Component.(consumer.Traces), tb.ConnectorConsumedItems, tb.ConnectorConsumedSize)
case pipeline.SignalMetrics:
n.Component, err = builder.CreateMetricsToProfiles(ctx, set, next)
if err != nil {
return err
}
n.consumer = obsconsumer.NewMetrics(n.Component.(consumer.Metrics), tb.ConnectorConsumedItems)
n.consumer = obsconsumer.NewMetrics(n.Component.(consumer.Metrics), tb.ConnectorConsumedItems, tb.ConnectorConsumedSize)
case pipeline.SignalLogs:
n.Component, err = builder.CreateLogsToProfiles(ctx, set, next)
if err != nil {
return err
}
n.consumer = obsconsumer.NewLogs(n.Component.(consumer.Logs), tb.ConnectorConsumedItems)
n.consumer = obsconsumer.NewLogs(n.Component.(consumer.Logs), tb.ConnectorConsumedItems, tb.ConnectorConsumedSize)
}
return nil
}
Expand Down
8 changes: 4 additions & 4 deletions service/internal/graph/exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,25 +67,25 @@ func (n *exporterNode) buildComponent(
if err != nil {
return fmt.Errorf("failed to create %q exporter for data type %q: %w", set.ID, n.pipelineType, err)
}
n.consumer = obsconsumer.NewTraces(n.Component.(consumer.Traces), tb.ExporterConsumedItems)
n.consumer = obsconsumer.NewTraces(n.Component.(consumer.Traces), tb.ExporterConsumedItems, tb.ExporterConsumedSize)
case pipeline.SignalMetrics:
n.Component, err = builder.CreateMetrics(ctx, set)
if err != nil {
return fmt.Errorf("failed to create %q exporter for data type %q: %w", set.ID, n.pipelineType, err)
}
n.consumer = obsconsumer.NewMetrics(n.Component.(consumer.Metrics), tb.ExporterConsumedItems)
n.consumer = obsconsumer.NewMetrics(n.Component.(consumer.Metrics), tb.ExporterConsumedItems, tb.ExporterConsumedSize)
case pipeline.SignalLogs:
n.Component, err = builder.CreateLogs(ctx, set)
if err != nil {
return fmt.Errorf("failed to create %q exporter for data type %q: %w", set.ID, n.pipelineType, err)
}
n.consumer = obsconsumer.NewLogs(n.Component.(consumer.Logs), tb.ExporterConsumedItems)
n.consumer = obsconsumer.NewLogs(n.Component.(consumer.Logs), tb.ExporterConsumedItems, tb.ExporterConsumedSize)
case xpipeline.SignalProfiles:
n.Component, err = builder.CreateProfiles(ctx, set)
if err != nil {
return fmt.Errorf("failed to create %q exporter for data type %q: %w", set.ID, n.pipelineType, err)
}
n.consumer = obsconsumer.NewProfiles(n.Component.(xconsumer.Profiles), tb.ExporterConsumedItems)
n.consumer = obsconsumer.NewProfiles(n.Component.(xconsumer.Profiles), tb.ExporterConsumedItems, tb.ExporterConsumedSize)
default:
return fmt.Errorf("error creating exporter %q for data type %q is not supported", set.ID, n.pipelineType)
}
Expand Down
Loading
Loading