client: add Metadata.Keys method #12805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for discovering the client metadata keys. At the moment it is only possible to get the values for a known key. Closes open-telemetry#12804
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12805 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 487 487
Lines 26808 26810 +2
=======================================
+ Hits 24511 24513 +2
Misses 1814 1814
Partials 483 483 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmacd
approved these changes
Apr 7, 2025
Contributor
jmacd
left a comment
jmacd
left a comment
There was a problem hiding this comment.
I have assumed this was an intentional restriction, in the past. ;)
dmathieu
approved these changes
Apr 8, 2025
atoulme
approved these changes
Apr 10, 2025
mx-psi
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for iterating over the client metadata keys.
At the moment it is only possible to get the values for a known key, which makes it impossible to inspect metadata keys without prior knowledge of all possible keys, e.g. as described in open-telemetry/opentelemetry-collector-contrib#39157.
Link to tracking issue
Closes #12804
Testing
Trivial addition, added unit tests.
Documentation
N/A