Skip to content

Conversation

@bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1276 into master will decrease coverage by 0.00%.
The diff coverage is 96.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
- Coverage   88.63%   88.62%   -0.01%     
==========================================
  Files         211      214       +3     
  Lines       15168    15179      +11     
==========================================
+ Hits        13444    13453       +9     
- Misses       1289     1290       +1     
- Partials      435      436       +1     
Impacted Files Coverage Δ
...eceiver/internal/scraper/processscraper/factory.go 75.00% <50.00%> (-25.00%) ⬇️
...eceiver/internal/scraper/cpuscraper/cpu_scraper.go 87.50% <100.00%> (-0.74%) ⬇️
...icsreceiver/internal/scraper/cpuscraper/factory.go 100.00% <100.00%> (ø)
...eiver/internal/scraper/diskscraper/disk_scraper.go 92.59% <100.00%> (-0.27%) ⬇️
...csreceiver/internal/scraper/diskscraper/factory.go 100.00% <100.00%> (ø)
...iver/internal/scraper/filesystemscraper/factory.go 71.42% <100.00%> (ø)
...al/scraper/filesystemscraper/filesystem_scraper.go 81.57% <100.00%> (-1.35%) ⬇️
...csreceiver/internal/scraper/loadscraper/factory.go 100.00% <100.00%> (ø)
...eiver/internal/scraper/loadscraper/load_scraper.go 91.30% <100.00%> (-0.70%) ⬇️
...receiver/internal/scraper/memoryscraper/factory.go 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0aa7c7...3ae329c. Read the comment docs.

Copy link
Member

@james-bebbington james-bebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks. Couple of minor comments

@bogdandrutu bogdandrutu merged commit 9d557be into open-telemetry:master Jul 7, 2020
@bogdandrutu bogdandrutu deleted the scraperobs branch July 7, 2020 23:31
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…#1276)

* Remove quotes from UnmarshalJSON

Signed-off-by: Daniil Rutskiy <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Daniil Rutskiy <[email protected]>

* Fix issue number in CHANGELOG.md

* Fix 'Code.UnmarshalJSON' to work with valid json only

Signed-off-by: Daniil Rutskiy <[email protected]>

* Extend test data for TestCodeUnmarshalJSONErrorInvalidData

Signed-off-by: Daniil Rutskiy <[email protected]>

* Delete useless cond, extend test data

Signed-off-by: Daniil Rutskiy <[email protected]>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
* add owent as reviewer

* fix order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants