-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add observability report wrapper for scrapers and use it everywhere #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1276 +/- ##
==========================================
- Coverage 88.63% 88.62% -0.01%
==========================================
Files 211 214 +3
Lines 15168 15179 +11
==========================================
+ Hits 13444 13453 +9
- Misses 1289 1290 +1
- Partials 435 436 +1
Continue to review full report at Codecov.
|
james-bebbington
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks. Couple of minor comments
receiver/hostmetricsreceiver/internal/scraper/obsreportscraper/obsreportscraper.go
Outdated
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/obsreportscraper/obsreportscraper_test.go
Outdated
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/obsreportscraper/obsreportscraper_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Bogdan Drutu <[email protected]>
…pen-telemetry#1276) Signed-off-by: Bogdan Drutu <[email protected]>
…#1276) * Remove quotes from UnmarshalJSON Signed-off-by: Daniil Rutskiy <[email protected]> * Update CHANGELOG.md Signed-off-by: Daniil Rutskiy <[email protected]> * Fix issue number in CHANGELOG.md * Fix 'Code.UnmarshalJSON' to work with valid json only Signed-off-by: Daniil Rutskiy <[email protected]> * Extend test data for TestCodeUnmarshalJSONErrorInvalidData Signed-off-by: Daniil Rutskiy <[email protected]> * Delete useless cond, extend test data Signed-off-by: Daniil Rutskiy <[email protected]>
* add owent as reviewer * fix order
No description provided.