[exporter/otlp] mark BatcherConfig as deprecated #12726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config for batcher is moving to queue configuration. Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
| // Experimental: This configuration is at the early stage of development and may change without backward compatibility | ||
| // until https://github.com/open-telemetry/opentelemetry-collector/issues/8122 is resolved | ||
| // | ||
| // Deprecated: [v0.123.0] batch configuration moving to queue configuration. |
There was a problem hiding this comment.
Let's log something if enabled. Potentially add a featuregate and error if this is used, so users can easily still use it?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12726 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 480 480
Lines 26456 26456
=======================================
Hits 24218 24218
Misses 1772 1772
Partials 466 466 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iblancasa
reviewed
Mar 25, 2025
Signed-off-by: Alex Boten <[email protected]>
bogdandrutu
approved these changes
Mar 26, 2025
|
@codeboten I extended this PR in #12748. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config for batcher is moving to queue configuration.