Skip to content

Conversation

@bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from a team, dmathieu, dmitryax and mx-psi as code owners March 19, 2025 20:11
@bogdandrutu bogdandrutu force-pushed the deprecate-with-request-queue branch from 8a7de37 to 3927f50 Compare March 19, 2025 20:12
}

// QueueBatchConfig defines configuration for queueing and batching for the exporter.
type QueueBatchConfig = exporterqueue.Config
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment still use the old queue Config until we do the transition to the newly defined Config. We will do a slow move to that.

@bogdandrutu bogdandrutu force-pushed the deprecate-with-request-queue branch from 3927f50 to 4320873 Compare March 19, 2025 20:16
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.55%. Comparing base (54222b6) to head (4320873).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/queue_batch.go 71.42% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (87.87%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12679      +/-   ##
==========================================
- Coverage   91.66%   91.55%   -0.12%     
==========================================
  Files         479      480       +1     
  Lines       26355    26391      +36     
==========================================
+ Hits        24159    24162       +3     
- Misses       1733     1766      +33     
  Partials      463      463              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 19, 2025
Merged via the queue into open-telemetry:main with commit 12dd09f Mar 19, 2025
54 of 55 checks passed
@bogdandrutu bogdandrutu deleted the deprecate-with-request-queue branch March 19, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants