Skip to content

Conversation

@mx-psi
Copy link
Member

@mx-psi mx-psi commented Sep 4, 2024

Description

Removes some helpers from extensiontest related to the componentstatus package.

As the following Github searches show, these symbols are not used by any public package outside of opentelemetry-collector and its forks:

Therefore, I think we can safely remove this in one go.

Link to tracking issue

Updates #11005

@mx-psi mx-psi force-pushed the mx-psi/move-extensionstatus branch from e1deb64 to d57a665 Compare September 4, 2024 10:58
@mx-psi mx-psi added the release:blocker The issue must be resolved before cutting the next release label Sep 4, 2024
@mx-psi mx-psi requested review from TylerHelmuth and mwear September 4, 2024 11:00
@mx-psi mx-psi marked this pull request as ready for review September 4, 2024 11:01
@mx-psi mx-psi requested a review from a team September 4, 2024 11:01
@codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (46d0f73) to head (a74c6c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11044      +/-   ##
==========================================
- Coverage   92.23%   92.22%   -0.01%     
==========================================
  Files         406      405       -1     
  Lines       19101    19086      -15     
==========================================
- Hits        17618    17603      -15     
  Misses       1123     1123              
  Partials      360      360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 752ec37 into open-telemetry:main Sep 4, 2024
@github-actions github-actions bot added this to the next release milestone Sep 4, 2024
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:blocker The issue must be resolved before cutting the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants