[service] implement a noop tracer provider#11026
Merged
codeboten merged 3 commits intoSep 5, 2024
Merged
Conversation
mx-psi
reviewed
Sep 4, 2024
Contributor
Author
I attended the go SIG on 28-Aug-2024, and the end result of the discussion was that because the no-op tracer still has to propagate context, the proposed solution if we need an alternative was to implement our own no-op tracer provider. |
This is to address some of the memory concerns around the SDK's noop tracer provider. Instead of using the published noop tracer provider, we implement our own to avoid the cost of context propagation, which has been proven to be high enough to cause issues for end users. Part of open-telemetry#10858 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/noop-providers
branch
from
September 5, 2024 17:57
94b236d to
c7197a8
Compare
codeboten
marked this pull request as ready for review
September 5, 2024 17:57
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
mx-psi
approved these changes
Sep 5, 2024
TylerHelmuth
approved these changes
Sep 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11026 +/- ##
==========================================
- Coverage 92.21% 92.20% -0.02%
==========================================
Files 405 405
Lines 19240 19244 +4
==========================================
Hits 17743 17743
- Misses 1130 1134 +4
Partials 367 367 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address some of the memory concerns around the SDK's noop tracer provider. Instead of using the published noop tracer provider, we implement our own to avoid the cost of context propagation, which has been proven to be high enough to cause issues for end users.
Part of #10858