Skip to content

[component] add LeveledMeterProvider #10931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 20, 2024
Merged

[component] add LeveledMeterProvider #10931

merged 3 commits into from
Aug 20, 2024

Conversation

@codeboten
Copy link
Contributor

@codeboten codeboten commented Aug 20, 2024

This func will MeterProvider and MetricsLevel in the near future. Split from #10912

@codeboten
[component] add LeveledMeterProvider
b104eca 
This func will MeterProvider and MetricsLevel in the near future. Split from open-telemetry#10912

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested review from a team and atoulme August 20, 2024 19:18
codeboten
codeboten commented Aug 20, 2024
View reviewed changes
codeboten
codeboten commented Aug 20, 2024
View reviewed changes
@codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.66%. Comparing base (f1fe602) to head (87a4c5f).
Report is 2 commits behind head on main.

Files Patch % Lines
service/service.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10931      +/-   ##
==========================================
- Coverage   91.68%   91.66%   -0.03%     
==========================================
  Files         404      404              
  Lines       18947    18946       -1     
==========================================
- Hits        17371    17366       -5     
- Misses       1217     1220       +3     
- Partials      359      360       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codeboten added a commit to codeboten/opentelemetry-collector that referenced this pull request Aug 20, 2024
@codeboten
[mdatagen] add LeveledMeter method
725614c 
This will use the LeveledMeterProvider in TelemetrySettings.

Split from open-telemetry#10912, follows open-telemetry#10931

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this pull request Aug 20, 2024
Merged
TylerHelmuth
TylerHelmuth reviewed Aug 20, 2024
View reviewed changes
@codeboten codeboten merged commit 3c1cf33 into open-telemetry:main Aug 20, 2024
@codeboten codeboten deleted the codeboten/leveled-meter-split-2 branch August 20, 2024 20:57
@github-actions github-actions bot added this to the next release milestone Aug 20, 2024
codeboten added a commit that referenced this pull request Aug 21, 2024
@codeboten
[mdatagen] add LeveledMeter method (#10933)
070e855 
This will use the LeveledMeterProvider in TelemetrySettings.
    
Split from
#10912,
follows #10931

---------

Signed-off-by: Alex Boten <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Oct 11, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
8833599 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Oct 11, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
8daec78 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Oct 11, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
b0a127f 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Oct 11, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
3f595d9 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Oct 21, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
3544610 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Oct 21, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
fa6ca74 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Nov 14, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
58ab4b6 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Nov 14, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
de46f3e 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Nov 14, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
8e86ba1 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Nov 14, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
a0305e4 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Nov 14, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
e957865 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Nov 14, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
dd0b7b1 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Nov 14, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
de2d84f 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Nov 14, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
786ff0f 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Nov 14, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
cf963b5 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Nov 15, 2024
@bogdandrutu
Rever public API changes in open-telemetry#10931, preserve logic
829446c 
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit that referenced this pull request Nov 16, 2024
@bogdandrutu
Revert public API changes in #10931, preserve logic (#11415)
8e522ad 
This PR removes APIs that expose `configtelemetry.Level`. Internal
functionality still uses the Level, but will be soon changed to use the
new Instrument.Enabled.

Signed-off-by: Bogdan Drutu <[email protected]>
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
@bogdandrutu @djaglowski
Revert public API changes in open-telemetry#10931, preserve logic (op…
84f95a2 
…en-telemetry#11415)

This PR removes APIs that expose `configtelemetry.Level`. Internal
functionality still uses the Level, but will be soon changed to use the
new Instrument.Enabled.

Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@atoulme atoulme Awaiting requested review from atoulme

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.108.0

Development

Successfully merging this pull request may close these issues.

2 participants

@codeboten @TylerHelmuth