Move exporter builder into internal service #10783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
force-pushed
the
move-exporter-builder
branch
2 times, most recently
from
755801d to
39583e7
Compare
dmathieu
force-pushed
the
move-exporter-builder
branch
from
39583e7 to
07b93d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10783 +/- ##
==========================================
+ Coverage 91.85% 91.87% +0.01%
==========================================
Files 409 410 +1
Lines 19226 19268 +42
==========================================
+ Hits 17660 17702 +42
Misses 1217 1217
Partials 349 349 ☔ View full report in Codecov by Sentry. |
dmathieu
force-pushed
the
move-exporter-builder
branch
from
eb01fce to
587fa93
Compare
dmathieu
force-pushed
the
move-exporter-builder
branch
from
587fa93 to
5f2e5b4
Compare
dmathieu
force-pushed
the
move-exporter-builder
branch
2 times, most recently
from
335e25e to
484f56c
Compare
dmathieu
force-pushed
the
move-exporter-builder
branch
from
484f56c to
7ea8a3a
Compare
mx-psi
approved these changes
Aug 22, 2024
|
Looks like the merge went wrong 🤔 |
dmathieu
force-pushed
the
move-exporter-builder
branch
from
dc9d21e to
98f7fcc
Compare
|
Sorry about that. I have fixed it. |
mx-psi
pushed a commit
that referenced
this pull request
Aug 30, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description There builders were deprecated in 0.108.0, so they can be removed now. PRs that deprecated the builders: * #10781 * #10782 * #10783 * #10784 * #10785 cc @mx-psi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the exporter builder out of the
exporterpackage, and intoservice/internal/builders.There's no real reason for this struct to be public (folks shouldn't call it), and making it private will allow us to add profiling support to it.
Link to tracking issue
#10375 (review)