Skip to content

Conversation

@codeboten
Copy link
Contributor

Finishing CreateSettings rename.

@codecov
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.38%. Comparing base (2449345) to head (1c49567).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10423      +/-   ##
==========================================
+ Coverage   92.33%   92.38%   +0.04%     
==========================================
  Files         403      403              
  Lines       18734    18724      -10     
==========================================
  Hits        17298    17298              
+ Misses       1076     1066      -10     
  Partials      360      360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten marked this pull request as ready for review June 18, 2024 17:30
@codeboten codeboten requested review from a team and TylerHelmuth June 18, 2024 17:30
codeboten added a commit to codeboten/opentelemetry-collector-contrib that referenced this pull request Jun 19, 2024
This dependency broke because of open-telemetry/opentelemetry-collector#10423, bumping the dep to unblock the core PR.

Signed-off-by: Alex Boten <[email protected]>
codeboten added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jun 20, 2024
This dependency broke because of
open-telemetry/opentelemetry-collector#10423,
bumping the dep to unblock the core PR.

Signed-off-by: Alex Boten <[email protected]>
@codeboten
Copy link
Contributor Author

Blocked by #10447

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Jul 17, 2024
@mx-psi
Copy link
Member

mx-psi commented Jul 18, 2024

I think this is no longer blocked, right?

…uncs/structs

Finishing CreateSettings rename.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/rm-deprecated-103 branch from 7f53d37 to 17c721f Compare July 18, 2024 20:18
@mx-psi
Copy link
Member

mx-psi commented Jul 19, 2024

# github.com/open-telemetry/otel-arrow/collector/netstats
Error: /home/runner/go/pkg/mod/github.com/open-telemetry/otel-arrow/[email protected]/netstats/netstats.go:138:51: undefined: exporter.CreateSettings
Error: /home/runner/go/pkg/mod/github.com/open-telemetry/otel-arrow/[email protected]/netstats/netstats.go:173:51: undefined: receiver.CreateSettings

@codeboten
Copy link
Contributor Author

@mx-psi pulled in the PR that removed the dependency. will see if it passes the CI now

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did! 🚀

@codeboten codeboten merged commit e590ed1 into open-telemetry:main Jul 19, 2024
@codeboten codeboten deleted the codeboten/rm-deprecated-103 branch July 19, 2024 15:13
@github-actions github-actions bot added this to the next release milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants