[mdatagen] add support for optional internal metrics #10316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10316 +/- ##
==========================================
- Coverage 92.56% 92.55% -0.01%
==========================================
Files 387 387
Lines 18254 18267 +13
==========================================
+ Hits 16896 16907 +11
- Misses 1014 1015 +1
- Partials 344 345 +1 ☔ View full report in Codecov by Sentry. |
codeboten
force-pushed
the
codeboten/optional-internal-metric
branch
from
8618bc0 to
ea36283
Compare
jpkrohling
reviewed
Jun 7, 2024
This allows metrics to be initialized at a later time as is the case for the queue metrics in exporterhelper which are only initialized if a queue is configured. Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/optional-internal-metric
branch
from
8748f96 to
2d5e29b
Compare
jpkrohling
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows metrics to be initialized at a later time as is the case for the queue metrics in exporterhelper which are only initialized if a queue is configured.