[service] use mdatagen for service metrics #10273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10273 +/- ##
==========================================
- Coverage 92.56% 92.52% -0.04%
==========================================
Files 387 388 +1
Lines 18254 18297 +43
==========================================
+ Hits 16896 16929 +33
- Misses 1014 1022 +8
- Partials 344 346 +2 ☔ View full report in Codecov by Sentry. |
This reverts the reverts open-telemetry#10271 and adds a mechanism to skip adding a create settings method for the service package component test. Will need to figure out if servicetelemetry.TelemetrySettings should be renamed to fit w/ the other CreateSettings structs before removing this check. Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/revert-revert10bcef33e6d26104036ed2874cb179c4437abc98
branch
from
8091e6c to
58a946a
Compare
…2874cb179c4437abc98
jpkrohling
approved these changes
Jun 10, 2024
| ignore: | ||
| top: | ||
| # See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
| - "go.opencensus.io/stats/view.(*worker).start" |
There was a problem hiding this comment.
This is because of ./internal/proctelemetry/config.go only, right?
codeboten
deleted the
codeboten/revert-revert10bcef33e6d26104036ed2874cb179c4437abc98
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the reverts #10271 and adds a mechanism to skip adding a create settings method for the service package component test. Will need to figure out if servicetelemetry.TelemetrySettings should be renamed to fit w/ the other CreateSettings structs before removing this check.