Support parsing metric.metadata from OTLP JSON #10026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10026 +/- ##
=======================================
Coverage 91.55% 91.56%
=======================================
Files 360 360
Lines 16693 16698 +5
=======================================
+ Hits 15284 15289 +5
Misses 1073 1073
Partials 336 336 ☔ View full report in Codecov by Sentry. |
dashpole
force-pushed
the
json_metric_metadata
branch
from
1b2be75 to
b91f45a
Compare
songy23
approved these changes
Apr 24, 2024
dashpole
force-pushed
the
json_metric_metadata
branch
4 times, most recently
from
ef1ab4b to
54509f4
Compare
dashpole
force-pushed
the
json_metric_metadata
branch
from
54509f4 to
c5949c0
Compare
codeboten
approved these changes
Apr 26, 2024
andrzej-stencel
pushed a commit
to andrzej-stencel/opentelemetry-collector
that referenced
this pull request
May 27, 2024
Follow-up to open-telemetry#10006, which added metric.metadata to pmetric. I forgot to add support for parsing the field from JSON in that PR. This PR adds the missing support. #### Testing Unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #10006, which added metric.metadata to pmetric.
I forgot to add support for parsing the field from JSON in that PR. This PR adds the missing support.
Testing
Unit tests