docker-component on Makefile fails on otelsvc

[etsangsplk]

GO111MODULE=on CGO_ENABLED=0 go build -o ./bin/otelsvc_linux -ldflags "-X github.com/open-telemetry/opentelemetry-service/internal/version.GitHash=2a40f54 " ./cmd/otelsvc
cp ./bin/ocotelsvc_linux ./cmd/ocotelsvc/
cp: directory ./cmd/ocotelsvc does not exist

Because:

docker-component is assuming all component has a "oc" prefix.

docker-otelsvc:
COMPONENT=otelsvc $(MAKE) docker-component <<--

[tigrannajaryan]

I can reproduce the failure on make docker-collector but not on make docker-otelsvc. The later passes successfully.

[tigrannajaryan]

@pjanotti Rather than trying to fix I suggest to remove target docker-collector from makefile. We only need the unified docker-otelsvc.
Having docker-collector in the makefile is misleading and unnecessary.
Thoughts?

[pjanotti]

I think it is a good idea since the collector is temporarily present just to help with compatibility tests, the real target is otelsvc.

[tigrannajaryan]

Sounds good. I'll remove docker-collector target, but will keep collector which builds the binary and which can be used in compatibitity tests if needed (the testbed is executing the binary directly, it doesn't need the docker image).

[tigrannajaryan]

@etsangsplk docker-component target does not depend on otelsvc target. Can you provide exact reproduction steps? Are you running make docker-otelsvc on Mac?

Also, where do you see oc$(COMPONENT)? It is nowhere in makefile.

[etsangsplk]

Mine repo is old. It was removed 4 days ago. Sync to master and it is now fine.

8772c90

[tigrannajaryan]

OK, good to know. Thanks for reporting the issue anyway. I am going to remove docker-component target to avoid confusion in the future.

[tigrannajaryan]

Done, closing the issue.