Skip to content

Configmiddleware: "middlewares" or "middleware"? #13444

@jmacd

Description

@jmacd

Part of #13422.

Component(s)

configmiddleware

What happened?

Describe the bug
configgrpc has a []configmiddleware.Config named "middlewares".
confighttp has a []configmiddleware.Config named "middleware".

Steps to reproduce
One of these is incorrect.

What did you expect to see?
One of these is incorrect. I believe the plural form is more correct?

What did you see instead?
Confusion. :-)

Collector version

v0.130.0

Environment information

No response

OpenTelemetry Collector configuration

Log output

Additional context

#12846 #12845

Tip

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions