-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Description
Once #12217 is implemented, we now have wrappers in place to automatically add component-identifying attributes (as defined by the Pipeline Component Telemetry RFC) to log records (see #12259) and metric points / spans (see #12384).
We also have an API so components can opt out of specific attributes in case they aren't relevant to them (for example, the OTLP receiver is a singleton shared for all signals, so the signal attribute is not relevant, see code).
However, this API is currently internal while it is being worked on. We want to eventually stabilize it and make it available to components outside of core as part of the component module.
To do this:
- The
TelemetrySettingsstruct, which in Wrap TelemetrySettings providers to add component-identifying attributes #12384 is moved tointernal/telemetryand reexported incomponent, should be moved back intocomponent. - The API functions that take a
TelemetrySettingsas first argument should be turned into methods for said struct (they are currently not because that would make them publicly available through the reexport)