Skip to content

Conversation

@mowies
Copy link
Member

@mowies mowies commented Jul 17, 2024

Fixes #471

Signed-off-by: Moritz Wiesinger <[email protected]>
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like #572 removed github.com/goreleaser/nfpm/v2 but did not tidy the go.mod file.

@mowies
Copy link
Member Author

mowies commented Jul 17, 2024

Seem like it should be fine. Marking as ready for review :)

@mowies mowies marked this pull request as ready for review July 17, 2024 11:02
@mowies mowies requested review from a team and TylerHelmuth July 17, 2024 11:02
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you file an issue about ensuring go.mod is tidy on CI?

@mx-psi mx-psi merged commit 19d291d into open-telemetry:main Jul 17, 2024
@mowies mowies deleted the update-go-mod-1-22 branch July 17, 2024 12:12
@mowies
Copy link
Member Author

mowies commented Jul 17, 2024

I filed a new issue now: #601

jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector-releases that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to Go 1.22 for official builds

2 participants