[chore] Split up cmd/goreleaser/internal/configure.go
#1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Camata <[email protected]>
mowies
changed the title
cmd/goreleaser/internal/configure.gocmd/goreleaser/internal/configure.go
mowies
reviewed
Nov 3, 2025
| return b | ||
| } | ||
|
|
||
| func (b *distributionBuilder) nightly() config.Nightly { |
There was a problem hiding this comment.
I think we could keep the consistency here and also rename this with new prefix
Suggested change
| func (b *distributionBuilder) nightly() config.Nightly { | |
| func (b *distributionBuilder) newNightly() config.Nightly { |
| return b | ||
| } | ||
|
|
||
| func (b *distributionBuilder) sboms() []config.SBOM { |
There was a problem hiding this comment.
Suggested change
| func (b *distributionBuilder) sboms() []config.SBOM { | |
| func (b *distributionBuilder) NewSboms() []config.SBOM { |
| return b | ||
| } | ||
|
|
||
| func (b *distributionBuilder) dockerSigns() []config.Sign { |
There was a problem hiding this comment.
Suggested change
| func (b *distributionBuilder) dockerSigns() []config.Sign { | |
| func (b *distributionBuilder) newDockerSigns() []config.Sign { |
| return b | ||
| } | ||
|
|
||
| func (b *distributionBuilder) binaryMonorepo(dir string) config.Monorepo { |
There was a problem hiding this comment.
Suggested change
| func (b *distributionBuilder) binaryMonorepo(dir string) config.Monorepo { | |
| func (b *distributionBuilder) newBinaryMonorepo(dir string) config.Monorepo { |
| return b | ||
| } | ||
|
|
||
| func (b *distributionBuilder) binaryRelease(header string) config.Release { |
There was a problem hiding this comment.
Suggested change
| func (b *distributionBuilder) binaryRelease(header string) config.Release { | |
| func (b *distributionBuilder) newBinaryRelease(header string) config.Release { |
| withDefaultBinaryRelease(opampReleaseHeader). | ||
| withDefaultMSIConfig(). | ||
| withDefaultNfpms(). | ||
| // This is required because of same non-obvious path/workdir handling in |
There was a problem hiding this comment.
Suggested change
| // This is required because of same non-obvious path/workdir handling in | |
| // This is required because of some non-obvious path/workdir handling in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a little house keeping that I promised a very long time ago. This breaks up the huge
cmd/goreleaser/internal/configure.gointo many files, so that it's easy to find things and scroll around, particularly when it comes to looking at how we build the goreleaser configuration file for each one of the distros.I'm very open to feedback on the names of the new files. Naming things is difficult.
Small note: I generate the goreleaser files of all distros during my work to ensure that these changes still produces the exact same files as before.