fix: setting IsMonotonic to true during Cumulative metric conversion#49826
Merged
songy23 merged 5 commits intoJul 22, 2026
Merged
Conversation
swapnil-signoz
requested review from
a team,
TylerHelmuth and
dashpole
as code owners
July 22, 2026 16:59
swapnil-signoz
changed the title
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
|
braydonk
approved these changes
Jul 22, 2026
braydonk
reviewed
Jul 22, 2026
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog) | ||
| component: exporter/elasticsearch | ||
| component: receiver/googlecloudmonitoringreceiver |
Contributor
There was a problem hiding this comment.
Suggested change
| component: receiver/googlecloudmonitoringreceiver | |
| component: receiver/googlecloudmonitoring |
braydonk
reviewed
Jul 22, 2026
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: "Allow `traces`, `profiles`, and `synthetics` as valid `data_stream.type` values when overriding via attributes in `bodymap` mapping mode, in addition to the existing `logs` and `metrics`." | ||
| note: "Fix cumulative metrics to be marked as monotonic" |
Contributor
There was a problem hiding this comment.
Suggested change
| note: "Fix cumulative metrics to be marked as monotonic" | |
| note: "CUMULATIVE metrics from Cloud Monitoring will now be properly marked as monotonic upon conversion" |
Pull request dashboard statusStatus last refreshed: 2026-07-22 19:05:11 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
braydonk
added
the
ready to merge
Contributor
|
Thank you for your contribution @swapnil-signoz! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
receiver/googlecloudmonitoring: GCP's cumulative metric kind maps to OTel's Monotonic Sum, but during conversion to OTel metric
IsMonotonicvalue is not being set. This PR adds theSetIsMonotoniccall and a test for it.Please check the issue attached below for more context.
Link to tracking issue
Fixes #49804
Testing
I have added test case which checks the converted metric has
IsMonotonicset to trueDocumentation
Not Applicable
Authorship