[pkg/translator/jaeger] Update semconv version#49468
Open
anarwal wants to merge 7 commits into
Open
Conversation
Pull request dashboard statusStatus last refreshed: 2026-07-23 03:07:50 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
iblancasa
reviewed
Jul 20, 2026
| if httpCodeAttr, ok := attrs.Get(string(conventions.HTTPResponseStatusCodeKey)); ok { | ||
| return httpCodeAttr, true | ||
| } | ||
| return attrs.Get("http.status_code") |
Member
There was a problem hiding this comment.
I'm not sure what to do in these cases. Maybe import the last version of the semantic conventions which supported this attribute?
Contributor
Author
There was a problem hiding this comment.
@iblancasa I have updated and should be ready for review
anarwal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pkg/translator/jaeger/jaegerproto_to_traces.go— Removed conventionsv125 import (v1.25.0), replaced conventionsv125.HTTPStatusCodeKey with string literal "http.status_code". No feature gate needed.Link to tracking issue
Fixes
pkg/translator/jaegerfrom #22095Testing
Ran
go mod tidy && go build ./... && go test ./...frompkg/translator/jaegerAuthorship