[chore] Refactor azurelogs/testdata for different log types #44436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
MikeGoldsmith,
constanca-m and
cparkins
constanca-m
approved these changes
Nov 21, 2025
atoulme
approved these changes
Nov 21, 2025
Contributor
|
Thank you for your contribution @kaiyan-sheng! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
emreyalvac
pushed a commit
to emreyalvac/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2025
…emetry#44436) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR refactors the `pkg/translator/azurelogs/testdata` directory to improve organization and consistency, and corrects a category name to match actual Azure log data. Changes: - Combined all appservice*logs directories into a single appservicelog directory. - Combined corner case directories (badlevel, badtime, maximum, minimum, minimum2) into a single `cornercases` directory. - Renamed azurecdnaccesslog to cdnaccesslog. - Standardized filenames by removing `log-` prefix from JSON files and use `_expected.yaml` suffix instead of `-expected.yaml`. - Use `-log` instead of `-logs` <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue N/A <!--Describe what testing was performed and which tests were added.--> #### Testing Changed the existing `resourcelogs_to_logs_test.go`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
pkg/translator/azurelogs/testdatadirectory to improve organization and consistency, and corrects a category name to match actual Azure log data.Changes:
cornercasesdirectory.log-prefix from JSON files and use_expected.yamlsuffix instead of-expected.yaml.-loginstead of-logsLink to tracking issue
N/A
Testing
Changed the existing
resourcelogs_to_logs_test.go.